Java: Finish dataflow refactor #12751
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atorralba
reviewed
Apr 4, 2023
java/ql/test/query-tests/security/CWE-798/semmle/tests/HardcodedCredentialsSourceCall.ql
Outdated
Show resolved
Hide resolved
| predicate sensitiveResultReceiver( | ||
| DataFlow::PathNode src, DataFlow::PathNode sink, DataFlow::Node recSrc | ||
| SensitiveResultReceiverFlow::PathNode src, SensitiveResultReceiverFlow::PathNode sink, |
There was a problem hiding this comment.
Won't this API change affect potential users of this predicate, since it's public? In other words: should we deprecate sensitiveResultReceiver and create a new predicate that uses SensitiveResultReceiverFlow::PathNode?
There was a problem hiding this comment.
Good point. I've done the deprecation in cac00b6.
atorralba
reviewed
Apr 6, 2023
| override predicate allowImplicitRead(DataFlow::Node node, DataFlow::ContentSet c) { | ||
| super.allowImplicitRead(node, c) | ||
| or | ||
| this.isSink(node) |
There was a problem hiding this comment.
This is still necessary. Note that the default implementation only allows implicit reads in sinks if defaultImplicitTaintRead holds, which is not the case here.
The failure in the tests is caused by this.
Co-authored-by: Tony Torralba <atorralba@users.noreply.github.com>
889a974
to
72907eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.