New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for JEA session leaking functions #19024
Conversation
Related work items: #152543
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Handy links: |
PR Summary
This PR corrects an issue with multiple modules loaded in a session and having functions with the same name. Previously all functions with that name become public even if only one module makes the function public.
PR Context
PowerShell's function list does not distinguish between session functions and module functions, and also does not allow duplicate function names. This caused some private module functions to be made publicly accessible. The fix is to update module function accessibility code to account for potential duplicate function names.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).