Swift: Add CSV extension points to the encryption queries. #12794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Apr 13, 2023
| exists(ClassOrStructDecl c, MethodDecl f, CallExpr call | | ||
| c.getName() = ["RNCryptor", "RNEncryptor", "RNDecryptor"] and | ||
| exists(NominalTypeDecl c, MethodDecl f, CallExpr call | | ||
| c.getName() = |
There was a problem hiding this comment.
Should this be getFullName like the other cases?
There was a problem hiding this comment.
Oh, well spotted!
Fixed both cases.
| exists(ClassOrStructDecl c, MethodDecl f, CallExpr call | | ||
| c.getName() = ["RNCryptor", "RNEncryptor", "RNDecryptor"] and | ||
| exists(NominalTypeDecl c, MethodDecl f, CallExpr call | | ||
| c.getName() = |
There was a problem hiding this comment.
Should this be getFullName like the other cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add MaD/CSV extension points to the eight encryption queries. Use them in two of the queries (I intend to take this a bit further at some point). Fix a few other bits and pieces around sinks for better reliability and consistency.