New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more itertools defined #15
Conversation
…e, and takewhile in itertools
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Might be good to have some test cases as well. |
…filterfalse, takewhile
|
Done! Thanks for the feedback |
|
Looks like you've committed some |
| break | ||
| assert tuple(got) == want, 'tuple(cycle%s) == %s, want %s' % (arg, tuple(got), want) | ||
|
|
||
| def testDropwhile(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def TestDropwhile? (capitalize)
|
Good catch. Should be fixed. Changed the .gitignore as well. |
|
Good work. I couldn't find any more problems. |
|
Awesome! I signed the CLA, but not sure why it's not going through. What can I do rectify? |
|
Really appreciate you taking this on! Not sure what's up with the CLA issue, but did you see this comment? #15 (comment) Do you have multiple emails associated with your GitHub account? If so, then make sure that the email that's associated with the git commits is the same one on the CLA? |
|
Yep, I double checked. Same e-mail (capitalization is different, but Github won't let me change it. Guessing that's not the issue) |
|
CLAs look good, thanks! |
|
@trotterdylan my CLI was setup with another e-mail account. Rewrote old commits with correct credentials! Wow, that was a weird one, great catch. |
|
Awesome. This all looks great. Can you make sure that "make precommit" is clean? |
|
Just to make sure I understand correctly: Run 'make precommit' in the root directory and make sure it runs without error? |
|
Right. The process should exit with status 0 (there may be output though). |
|
I get the following output. Thoughts? Tried to make clean as well. build/src/grumpy/builtin_types.go:587: z.Text undefined (type big.Int has no field or method Text) |
|
That's not a problem with your code. It may be that you have an older Go toolchain. Can you paste the output of "go version"? Mine is: $ go version |
|
Oops! Was a while since I updated Go. 'make precommit' runs with exit status 0! |
|
Awesome! Thanks for working on this! |

Added cycle, dropwhile, from_iterable, ifilter, ifilterfalse, and takewhile in itertools
The text was updated successfully, but these errors were encountered: