Swift: Modernize the encryption queries #12764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we're currently ignoring QLdoc check failures for |
Correct those should be considered as being inherited form the signature, but currently this is not picked up upon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the 8 Swift encryption queries. By 'modernize', I mean split into three files with standard layouts, extendable sinks etc in the usual way. Conversion to
DataFlow::ConfigSigis a separate process and has in fact already been done for these queries.I haven't yet added CSV extension points. That will be follow-up as, from past experience, it sometimes involves a bit more work and testing on individual queries.
I also haven't unified the various 'constant' sources some of these queries define - there's a separate issue for that at some point. And I haven't dealt with
IntLiteralSourcefromswift/insufficient-hash-iterations, as I want to redesign it a bit before making it extendable / public. I'm creating an issue for that as well.