Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41282: setup.py ignores distutils DeprecationWarning #25405

Merged
merged 2 commits into from Apr 14, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 14, 2021

@vstinner
Copy link
Member Author

vstinner commented Apr 14, 2021

cc @tirkarthi

@tirkarthi tirkarthi requested a review from zooba Apr 14, 2021
@tirkarthi
Copy link
Member

tirkarthi commented Apr 14, 2021

LGTM. It's better to silence these for now since setup.py is used in the build process. As per Steve's comment this will fail when distutils is moved inside tools directory and import paths need to be updated as noted in https://bugs.python.org/issue43425#msg388780.

@vstinner
Copy link
Member Author

vstinner commented Apr 14, 2021

As per Steve's comment this will fail when distutils is moved inside tools directory and import paths need to be updated as noted in https://bugs.python.org/issue43425#msg388780.

Python setup.py may be one of the last Python project to migrate to something else. Or Python will keep an old private copy of distutils ;-)

@vstinner vstinner merged commit d9ba9de into python:master Apr 14, 2021
11 checks passed
@vstinner vstinner deleted the setup_deprecated_distutils branch Apr 14, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants