Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

Closed
tiran opened this issue Jul 13, 2022 · 2 comments
Closed

configure: non pkg-config fallback ignores custom CFLAGS and LIBS #94801

tiran opened this issue Jul 13, 2022 · 2 comments
Assignees
@erlend-aasland
Labels
3.11 bug and security fixes 3.12 new features, bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Jul 13, 2022

Bug report

In configure.ac we have several fallbacks when pkg-config is missing or a package does not provide a .pc file. The fallbacks do not take custom cflags into account. For example the block for zlib does AC_CHECK_HEADERS([zlib.h]) and AC_CHECK_LIB([z]) without setting CFLAGS="$CFLAGS $ZLIB_CFLAGS" first.
@tiran tiran added type-bug An unexpected behavior, bug, or error build The build process and cross-build 3.11 bug and security fixes 3.12 new features, bug and security fixes labels Jul 13, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 13, 2022
Merged
tiran added a commit to tiran/cpython that referenced this issue Jul 14, 2022
@tiran
pythongh-94801: Use custom flags to check for headers and libs
7bb04f3
tiran added a commit that referenced this issue Jul 15, 2022
@tiran
gh-94801: Use custom flags to check for headers and libs (#94802)
944ff8c
tiran added a commit to tiran/cpython that referenced this issue Jul 15, 2022
@tiran
[3.11] pythongh-94801: Use custom flags to check for headers and libs (…
96e6bec 
…pythonGH-94802).

(cherry picked from commit 944ff8c)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jul 15, 2022
Merged
tiran added a commit that referenced this issue Jul 18, 2022
@tiran
[3.11] gh-94801: Use custom flags to check for headers and libs (GH-9…
30412d9 
…4802) (GH-94881)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Member Author

tiran commented Jul 25, 2022

@erlend-aasland is there anything left to do? I think we are done here.

@erlend-aasland
Copy link
Contributor

AFAICS, yes. Let's close it. If another issue surfaces, we can always open a new ticket, or just reopen this.

tiran added a commit to tiran/cpython that referenced this issue Jul 26, 2022
@tiran
pythongh-94801: Fix regression in configure's CPPFLAGS handling
15a5d94
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
tiran added a commit that referenced this issue Jul 26, 2022
@tiran
gh-94801: Fix regression in configure's CPPFLAGS handling (GH-95288)
9af7f87
tiran added a commit to tiran/cpython that referenced this issue Jul 26, 2022
@tiran
[3.11] pythongh-94801: Fix regression in configure's CPPFLAGS handling (
9526b00 
pythonGH-95288).

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot bedevere-bot mentioned this issue Jul 26, 2022
Merged
ambv pushed a commit that referenced this issue Jul 27, 2022
@tiran
[3.11] gh-94801: Fix regression in configure's CPPFLAGS handling (GH-…
c72c1d6 
…95288) (GH-95297)

(cherry picked from commit 9af7f87)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
3.11 bug and security fixes 3.12 new features, bug and security fixes build The build process and cross-build type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tiran @erlend-aasland