Improve pre-commit config #9563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -220,8 +221,9 @@ def get_precommit_requirements() -> dict[str, SpecifierSet]: | |||
| if not repo.get("python_requirement", True): | |||
| continue | |||
| hook = repo["hooks"][0] | |||
| package_name, package_rev = hook["id"], repo["rev"] | |||
| package_specifier = SpecifierSet(f"=={package_rev.removeprefix('v')}") | |||
| package_name = Path(urllib.parse.urlparse(repo["repo"]).path).name | |||
There was a problem hiding this comment.
Is this meant to be part of this PR?
There was a problem hiding this comment.
Yes. The test as it currently stands is poorly designed. Without this change, check_consistent.py fails if we add pre-commit-hooks to our pre-commit config, because of the fact that the hooks in the pre-commit-hooks repo have different names to the repo as a whole.
There was a problem hiding this comment.
Example failing run: https://github.com/python/typeshed/actions/runs/3949452817/jobs/6760681897
JelleZijlstra
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
trailing-whitespace: fixes trailing whitespacerequirements-txt-fixer: alphabetises items inrequirements.txtfilesend-of-file-fixer: makes sure every file ends with a single newline charactermixed-line-ending: Makes sure Windows users don't accidentally introduce CRLF line endings into a file that uses LF line endingscheck-yaml: loads YAML files to validate syntaxcheck-toml: loads TOML files to validate syntaxcheck-merge-conflict: detects merge-conflict strings in files and blocks them from accidentally being committedcheck-case-conflict: checks for files with names that would conflict on a case-insensitive filesystem like MacOS HFS+ or Windows FAT; blocks them from being committed.blacklanguage target-version to Python 3.10, synching the setting here with the changes that were made to ourpyproject.tomlfile in Update black target version to py310 #7538