Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actively supported type-checkers list in readme #9472

Merged
merged 3 commits into from Jan 6, 2023
Merged

Update actively supported type-checkers list in readme #9472

merged 3 commits into from Jan 6, 2023

Conversation

Avasam
Copy link
Sponsor Contributor

@Avasam Avasam commented Jan 6, 2023

  • Added pyright mention in readme (since typeshed actively supports it and works with it)
  • Add links to help navigate away readers looking for type-checkers
  • Add missing code-block

@Avasam
Update actively supported type-checkers list in readme
d326f96 
- Added pyright mention in readme
- Add links to help navigate away readers looking for type-checkers
- Add missing code-block
@Avasam
Copy link
Sponsor Contributor Author

Avasam commented Jan 6, 2023

Found it a bit weird pyright wasn't mentioned given its popularity and how actively it is used in typeshed.

hauntsaninja
hauntsaninja approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This wording probably predates pyright's existence entirely.

hauntsaninja
hauntsaninja reviewed Jan 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Avasam added a commit to Avasam/stub_uploader that referenced this pull request Jan 6, 2023
@Avasam
Mention pyright and PyCharm in the stubs' README
e4975cd 
Same suggestion as python/typeshed#9472
hauntsaninja
hauntsaninja reviewed Jan 6, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
Avasam and others added 2 commits January 6, 2023 16:41
@Avasam @hauntsaninja
Update README.md
4e704cf 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@Avasam @hauntsaninja
Update README.md
5a37ab9 
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@Avasam Avasam mentioned this pull request Jan 6, 2023
Merged
@hauntsaninja hauntsaninja merged commit e584337 into python:main Jan 6, 2023
1 check passed
@Avasam Avasam deleted the pyright-readme branch January 6, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Avasam @hauntsaninja