Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIf no path is found or when using the -ScriptDefinition parameter set, default to the current location for the directory search of the implicit settings file #979
Conversation
| $violations = Invoke-ScriptAnalyzer -Path $project1Root -Recurse | ||
| $violations.Count | Should -Be 1 | ||
| $violations[0].RuleName | Should -Be "PSAvoidUsingCmdletAliases" | ||
| } | ||
|
|
||
| It "runs rules from the implicit setting file using the -ScriptDefinition parameter set" { | ||
| Push-Location $project1Root |
This comment has been minimized.
This comment has been minimized.
kalgiz
Apr 27, 2018
Contributor
Can you, please, explain what is happening in here? Why are we pushing the $project1Root?
This comment has been minimized.
This comment has been minimized.
bergmeister
Apr 27, 2018
•
Author
Collaborator
Similar to the test above I am testing that PSSA implicitly picks up the settings file (see feature description here). PSSA goes through various search paths like e.g. the supplied path (test above) or current working directory (this test/PR) or even the Desktop.
| $violations = Invoke-ScriptAnalyzer -ScriptDefinition 'gci; Write-Host' -Recurse | ||
| Pop-Location | ||
| $violations.Count | Should -Be 1 | ||
| $violations[0].RuleName | Should -Be "PSAvoidUsingCmdletAliases" ` |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bergmeister
Apr 27, 2018
•
Author
Collaborator
Yes, we could use exact matching but I will need to apply that to surrounding test cases for consistency. I was wondering for a while if we should try to come up with a best practice example test template that we either document or even make a test helper method for it since nearly all PSSA tests are kind of the same...
bergmeister commentedApr 25, 2018
•
edited
PR Summary
Fixes #978. This allows usage of the implicit settings file when using the
-ScriptDefinitionparameter (or avoid a misleading error message about setting parsing when no file is found to be analysed). When no file path was found using the-Pathoption or using the-ScriptDefinitionparameter set, the search for implicit setting files used to rely on a path being present. This PR fixes it to fallback to the current working directory as a search directory for implicit setting file.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready