Skip to content

/ PSScriptAnalyzer

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AzF profile to be useful #1341

Merged
merged 3 commits into from Sep 14, 2019
Merged

Update AzF profile to be useful #1341

merged 3 commits into from Sep 14, 2019

Conversation

@rjmholt
Copy link
Member

rjmholt commented Sep 13, 2019

PR Summary

I've run the profile collector on the AzF profile (with some difficulty) and collected a new profile that captures the default Az installation.

I've also removed cmdlets that don't work in AzF despite being present, like Start-Job and Enter-PSSession.

I had to make some small changes to the profile collector to not crash (plus one where I realised that collecting a function if we're not able to load it is unhelpful).

PR Checklist
rjmholt added 2 commits Sep 13, 2019
@rjmholt
Fix collection issue
225f004
@rjmholt
Update AzF profile to be useful
Loading status checks…
098e4c0
@bergmeister
bergmeister reviewed Sep 13, 2019
View changes
Copy link
Collaborator

bergmeister left a comment

Looks ok to me but it broke 1 CI test:

    Context Targeting new-form Az profiles alongside older profiles
      [-] Finds AzF problems with a script 7.37s
        KeyNotFoundException: The given key 'InDisconnectedSession' was not present in the dictionary.
        at <ScriptBlock>, C:\projects\psscriptanalyzer\Tests\Rules\UseCompatibleCommands.Tests.ps1: line 334
@rjmholt
Copy link
Member Author

rjmholt commented Sep 13, 2019

Impressive that testing picked that up! I'll have to make some further edits
@rjmholt
Fix alias
Loading status checks…
0c5e342
@rjmholt
Copy link
Member Author

rjmholt commented Sep 14, 2019

Impressive that testing picked that up!

Have to credit you entirely for that @bergmeister -- you asked for those tests.

Looks like they're working now. Hopefully the Lazys don't hide other faults. I took out parameters and commands manually, and it looks like I took a parameter out without its alias there.
@bergmeister
bergmeister approved these changes Sep 14, 2019
View changes
@rjmholt rjmholt merged commit 5e207aa into PowerShell:master Sep 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergmeister bergmeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@rjmholt @bergmeister
You can’t perform that action at this time.