Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change module root find function in CompatibilityRule #1196

Merged
merged 3 commits into from Mar 28, 2019

Conversation

@rjmholt
Copy link
Member

rjmholt commented Mar 26, 2019

PR Summary

After @bergmeister's comments in @JamesWTruher's PR, I've made some small changes to the function that finds the PSScriptAnalyzer module root, the main one being that it will explicitly throw a FileNotFoundException when it gives up.

PR Checklist

@rjmholt rjmholt requested review from bergmeister and JamesWTruher Mar 26, 2019
rjmholt added 2 commits Mar 26, 2019
@rjmholt
Copy link
Member Author

rjmholt commented Mar 28, 2019

Will let someone else merge

@bergmeister bergmeister merged commit 7f05870 into PowerShell:development Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.