Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpload only out folder as artifact, which is the actual PSSA artifact #1009
Conversation
|
LGTM |
dc0b4a3
into
PowerShell:development
2 checks passed
2 checks passed
license/cla
All CLA requirements met.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
bergmeister commentedJun 2, 2018
•
edited
PR Summary
As per title, at the moment, we upload the full repo, which is not necessary, just the out folder is enough
Related #622
Should we document this and give details which build to choose (since all builds build only for their specific PowerShell version) and tell having to unblock the zip?
To fully close the issue we would need to change one of the build jobs to build for all PowerShell versions.
WDYT?
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.NAMake sure you've added a new test if existing tests do not effectively test the code changedWIP:to the beginning of the title and remove the prefix when the PR is ready