The "Pretty" PR #1305
Merged
The "Pretty" PR #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…easily run linters
martinRenou
reviewed
Mar 24, 2021
.github/workflows/build.yml
Outdated
| @@ -62,6 +63,9 @@ jobs: | |||
| yarn install | |||
| yarn run test | |||
| - name: Run prettyfier | |||
| run: yarn run prettier --check . | |||
There was a problem hiding this comment.
run: |
cd js
yarn run prettier --check .
There was a problem hiding this comment.
Ah, I thought it'd pick it up from the command above.
Thanks!
There was a problem hiding this comment.
I recall there was a working-directory option that you can use otherwise. Something like:
run: yarn run prettier --check .
working-directory: js
martinRenou
pushed a commit
to martinRenou/bqscales
that referenced
this issue
Aug 19, 2021
martinRenou
pushed a commit
to martinRenou/bqscales
that referenced
this issue
Aug 19, 2021
martinRenou
pushed a commit
to martinRenou/bqscales
that referenced
this issue
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds configuration for both prettier and eslint. Enforces prettier rules but not eslint rules.