Skip to content

chore: add generated methods#9896

Merged
srittau merged 4 commits intopython:mainfrom
henryiii:henryiii/chore/gendist
Mar 17, 2023
Merged

chore: add generated methods#9896
srittau merged 4 commits intopython:mainfrom
henryiii:henryiii/chore/gendist

Conversation

@henryiii
Copy link
Copy Markdown
Contributor

@henryiii henryiii commented Mar 16, 2023

Pulled out from #9895. Not sure why stubtest can't see these, they've been there forever:

https://github.com/pypa/setuptools/blob/be6c0218bcba78dbd4ea0b5a8bb9acd5d5306240/setuptools/_distutils/dist.py#L151-L153

https://github.com/python/cpython/blob/1bf9cc509326bc42cd8cb1650eb9bf64550d817e/Lib/distutils/dist.py#L159-L162

Looks like subtest just needs this added to some sort of ignore list.

@github-actions

This comment has been minimized.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@github-actions

This comment has been minimized.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@henryiii henryiii marked this pull request as ready for review March 17, 2023 03:53
Copy link
Copy Markdown
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 3a82796 into python:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants