Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy code for generator based coroutines in asyncio #102748

Open
kumaraditya303 opened this issue Mar 16, 2023 · 0 comments
Open

Remove legacy code for generator based coroutines in asyncio #102748

kumaraditya303 opened this issue Mar 16, 2023 · 0 comments
Labels
3.12 new features, bug and security fixes expert-asyncio

Comments

@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Mar 16, 2023 •
edited by bedevere-bot

Generator based coroutines were long deprecated and removed and asyncio doesn't not supports it. There is some left over code for supporting it which can be removed now.

The first thing is this behavior of asyncio.iscoroutine which makes no sense now. I propose to remove this first.

import asyncio

def gen():
    yield 1

assert not asyncio.iscoroutine(gen()) # fails

Linked PRs
@kumaraditya303 kumaraditya303 added expert-asyncio 3.12 new features, bug and security fixes labels Mar 16, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 16, 2023
Merged
kumaraditya303 added a commit that referenced this issue Mar 16, 2023
@kumaraditya303 @AlexWaygood
GH-102748: remove legacy support for generator based coroutines from …
adaed17 
…`asyncio.iscoroutine` (#102749)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 new features, bug and security fixes expert-asyncio
Projects
asyncio
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kumaraditya303