Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup config.AuthToken and config.DefaultHost methods #7049

Merged
merged 3 commits into from Feb 28, 2023
Merged

Conversation

samcoe
Copy link
Member

@samcoe samcoe commented Feb 27, 2023

This PR cleans us the uses of config.AuthToken() and config.DefaultHost() and replaces them with config.Authentication().Token() and config.Authentication().DefaultHost() respectively. There are no functional changes and all test changes are to do with changing the stub/mock mechanism.

Follow up: #7043.
cc: #449

@samcoe samcoe self-assigned this Feb 27, 2023
@samcoe samcoe mentioned this pull request Feb 27, 2023
@samcoe samcoe marked this pull request as ready for review February 27, 2023 02:16
@samcoe samcoe requested a review from a team as a code owner February 27, 2023 02:16
@samcoe samcoe requested review from vilmibm and removed request for a team February 27, 2023 02:16
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Feb 27, 2023
@samcoe samcoe requested a review from a team as a code owner February 27, 2023 02:29
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Feb 27, 2023
Base automatically changed from keyring-v3 to trunk February 28, 2023 00:04
@samcoe samcoe enabled auto-merge (squash) February 28, 2023 00:11
@samcoe samcoe merged commit c9a2d85 into trunk Feb 28, 2023
10 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Feb 28, 2023
@samcoe samcoe deleted the keyring-v4 branch February 28, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
The GitHub CLI
  
Pending Release 🥚
Development

Successfully merging this pull request may close these issues.

None yet

3 participants