fix psycopg.sql.Identifier in \ev handling #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 84.15% // Head: 80.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 84.15% 80.07% -4.08%
==========================================
Files 21 23 +2
Lines 2720 2148 -572
==========================================
- Hits 2289 1720 -569
+ Misses 431 428 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
|
Nice work @andyscho . |
rob-b
pushed a commit
to rob-b/pgcli
that referenced
this pull request
Nov 23, 2022
rob-b
pushed a commit
to rob-b/pgcli
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This fixes the issue outlined in #1372 by changing the psycopg.sql.Identifier. I would guess this problem originally entered the codebase relatively recently during the port to psycopg3.
Before this PR,
CREATE OR REPLACE VIEWwill not replace the view, and will instead create a new view with the name<schema>.<view>, leaving the original view unchanged.Adds extremely small test assertion to make sure the view is quoted correctly.
Checklist
changelog.rst.AUTHORSfile (or it's already there).pip install pre-commit && pre-commit install), and ranblackon my code.