Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup retries #7027

Merged
merged 7 commits into from Mar 2, 2023
Merged

Cleanup retries #7027

merged 7 commits into from Mar 2, 2023

Conversation

samcoe
Copy link
Member

@samcoe samcoe commented Feb 21, 2023 •
edited

This PR updates our many uses of backoffs throughout the codebase to use the cenkalti/backoff package.

Fixes #6985

@samcoe samcoe self-assigned this Feb 21, 2023
@samcoe samcoe marked this pull request as ready for review February 22, 2023 06:22
@samcoe samcoe requested review from a team as code owners February 22, 2023 06:22
@samcoe samcoe requested review from vilmibm and removed request for a team February 22, 2023 06:22
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Feb 22, 2023
cmbrose
cmbrose reviewed Feb 22, 2023
View changes
internal/codespaces/api/api.go Outdated Show resolved Hide resolved
cmbrose
cmbrose reviewed Feb 22, 2023
View changes
internal/codespaces/codespaces.go Outdated Show resolved Hide resolved
@samcoe samcoe requested a review from cmbrose February 28, 2023 02:51
cmbrose
cmbrose reviewed Mar 1, 2023
View changes
internal/codespaces/codespaces.go
}

codespace, err = apiClient.GetCodespace(ctx, codespace.Name, true)
if !connectionReady(codespace) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we put in some whitespace to break this up a bit? It's pretty dense to read 😄

cmbrose
cmbrose approved these changes Mar 1, 2023
View changes
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Mar 1, 2023
cmbrose
cmbrose approved these changes Mar 1, 2023
View changes
@samcoe samcoe enabled auto-merge (squash) March 2, 2023 22:58
@samcoe samcoe merged commit 35a24ca into trunk Mar 2, 2023
10 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Mar 2, 2023
@samcoe samcoe deleted the cleanup-retries branch March 2, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmbrose cmbrose cmbrose approved these changes

@vilmibm vilmibm

Assignees

@samcoe samcoe

Labels
None yet
Projects
The GitHub CLI
  
Pending Release 🥚
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unify backoff retry mechanisms
2 participants
@samcoe @cmbrose