Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: turn on QLdoc check #12373

Merged
merged 1 commit into from Mar 3, 2023
Merged

Swift: turn on QLdoc check #12373

merged 1 commit into from Mar 3, 2023
+1 −2

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Mar 2, 2023 •
edited

This was turned off during the early stage of porting the proof of concept to be ready for private beta, as documentation was not a focus of ours back then. Now we do want to bring documentation on par, so it was decided within the team to turn this on again.

@redsun82 redsun82 requested a review from a team as a code owner March 2, 2023 15:30
angelapwen
angelapwen approved these changes Mar 2, 2023
View changes
Copy link

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have a lot of context into this, but makes sense and seems to be passing the check.

@redsun82
Copy link
Contributor Author

redsun82 commented Mar 3, 2023

Don't have a lot of context into this, but makes sense and seems to be passing the check.

added some more context in the PR description 🙂

@redsun82 redsun82 merged commit 1a19909 into main Mar 3, 2023
7 checks passed
@redsun82 redsun82 deleted the redsun82/swift-qldoc branch March 3, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redsun82 @angelapwen