Skip to content

gh-101476: Use _PyType_GetModuleState where applicable#102188

Merged
erlend-aasland merged 2 commits intopython:mainfrom
erlend-aasland:apply-faster-getmodulestate
Feb 24, 2023
Merged

gh-101476: Use _PyType_GetModuleState where applicable#102188
erlend-aasland merged 2 commits intopython:mainfrom
erlend-aasland:apply-faster-getmodulestate

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented Feb 23, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Closed
@erlend-aasland erlend-aasland linked an issue Feb 23, 2023 that may be closed by this pull request
Add internal API for fast module access from heap type methods #101476
Closed
@erlend-aasland erlend-aasland mentioned this pull request Feb 23, 2023
Merged
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 23, 2023

I consider this a trivial and non-controversial PR; I intend to merge it as soon as the CI is green. If this turns out to be bad judgement from my side, I'm happy to revert it.

@corona10
Copy link
Copy Markdown
Member

corona10 commented Feb 24, 2023 •
edited
Loading

If this turns out to be bad judgement from my side, I'm happy to revert it.

I remember that there were some kinds of discussions to use public API as possible.
I will let you know once I find it.

cc @ericsnowcurrently

@corona10
Copy link
Copy Markdown
Member

corona10 commented Feb 24, 2023

Might be one piece of discussion I remember: #90699 (comment)

@ericsnowcurrently
Copy link
Copy Markdown
Member

ericsnowcurrently commented Feb 24, 2023

At least with _xxsubinterpreters, I purposefully did not use any internal API. Ideally, non-builtin extensions would avoid internal API, generally.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 24, 2023

@ericsnowcurrently, @corona10: As the PR title says, I've only applied this where applicable. This implies extension modules that define Py_BUILD_CORE_BUILTIN 1. For extension modules without this define, no change has been made.

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 24, 2023

I've reverted the change in _testmultiphase.

@ericsnowcurrently
Copy link
Copy Markdown
Member

ericsnowcurrently commented Feb 24, 2023

BTW, thanks for working on this, @erlend-aasland!

@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Feb 24, 2023

Thanks for comments and reviews, everyone!

@erlend-aasland erlend-aasland merged commit 568fc0d into python:main Feb 24, 2023
@erlend-aasland erlend-aasland deleted the apply-faster-getmodulestate branch February 24, 2023 20:16
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@erlend-aasland @JelleZijlstra
pythongh-101476: Use _PyType_GetModuleState where applicable (python#…
ee29b86 
…102188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran Awaiting requested review from tiran

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add internal API for fast module access from heap type methods

5 participants

@erlend-aasland @corona10 @ericsnowcurrently @kumaraditya303 @bedevere-bot