Merged
Conversation
Also add a few argument defaults
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Feb 9, 2023
| async def send_packed_command(self, command: bytes | str | Iterable[bytes], check_health: bool = ...): ... | ||
| async def send_command(self, *args, **kwargs) -> None: ... | ||
| async def read_response(self, disable_decoding: bool = ..., timeout: float | None = ...): ... | ||
| async def read_response(self, disable_decoding: bool = False, timeout: float | None = None) -> Incomplete | None: ... |
Member
There was a problem hiding this comment.
It will only return None if timeout is not None (and an asyncio.TimeoutError is raised), so you could possibly overload this:
Suggested change
| async def read_response(self, disable_decoding: bool = False, timeout: float | None = None) -> Incomplete | None: ... | |
| @overload | |
| async def read_response(self, disable_decoding: bool = False, timeout: float) -> Incomplete | None: ... | |
| @overload | |
| async def read_response(self, disable_decoding: bool = False, timeout: None = None) -> Incomplete: ... |
| async def connect_to(self, address) -> None: ... | ||
| async def connect(self): ... | ||
| async def read_response(self, disable_decoding: bool = ...): ... # type: ignore[override] | ||
| async def read_response(self, disable_decoding: bool = False, timeout: float | None = None) -> Incomplete | None: ... |
Member
There was a problem hiding this comment.
Same comment as with the method in redis.asyncio.client
AlexWaygood
approved these changes
Feb 10, 2023
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add a few argument defaults
Closes: #9479