Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete python-crontab #9306

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 30, 2022

Source: https://gitlab.com/doctormo/python-crontab

Source are very messy in some parts.
I've left several TODO items for the future, because some parts are quite complex.
I've also intentionally simplified some corner cases: for example some code might call a = int(b), so I annotated b: int | str, because this is what docs say for multiple cases.

This was not pleasant 馃槖

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2022

According to mypy_primer, this change has no effect on the checked open source code. 馃馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants