Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: add fflush() to SnapshotData::ToFile() #46531

Merged
merged 1 commit into from Feb 8, 2023
Merged

src: add fflush() to SnapshotData::ToFile() #46531

merged 1 commit into from Feb 8, 2023

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 6, 2023

@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/startup

@addaleax addaleax mentioned this pull request Feb 6, 2023
Merged
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Feb 6, 2023
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 6, 2023
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/49456/

jasnell
jasnell approved these changes Feb 7, 2023
View changes
cjihrig
cjihrig approved these changes Feb 7, 2023
View changes
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 7, 2023
lpinca
lpinca approved these changes Feb 7, 2023
View changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5092346 into nodejs:main Feb 8, 2023
59 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in 5092346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@lpinca lpinca

@cjihrig cjihrig

@tniessen tniessen

@joyeecheung joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@addaleax @nodejs-github-bot @jasnell @lpinca @cjihrig @tniessen @joyeecheung