Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PY: track string-constants to regular expression uses #11833

Merged
merged 2 commits into from Feb 1, 2023

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 6, 2023

CVE-2022-1930: TP/TN

Using an approach similar to the one currently used in Ruby.

An evaluation definitely shows a minor slowdown.
That slowdown makes sense because a lot more regular expressions are being analyzed.
And I think it's worth it.

@github-actions github-actions bot added the Python label Jan 6, 2023
tausbn
tausbn approved these changes Jan 31, 2023
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@erik-krogh erik-krogh merged commit 01f6862 into github:main Feb 1, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants