Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--include-unknown not functioning as expected #1939

Closed
Trenly opened this issue Feb 15, 2022 · 5 comments · Fixed by #1972
Closed

--include-unknown not functioning as expected #1939

Trenly opened this issue Feb 15, 2022 · 5 comments · Fixed by #1972
Labels
Issue-Bug Resolution-Fix-Committed
Milestone
v1.3-Client

Comments

@Trenly
Copy link
Contributor

@Trenly Trenly commented Feb 15, 2022

Brief description of your issue

When running winget upgrade it tells me a package has unknown version. When using --include-unknown the package with unknown version is not listed and the upgrade list does not change

Steps to reproduce

Have a package with unknown version, run winget upgrade --include-unknown

Expected behavior

A list of all upgradeable packages to be shown

Actual behavior

The list of packages does not change between winget upgrade and winget upgrade --unknown
Logs attached for reference.

PS C:\WINDOWS\system32> winget upgrade
Name    Id              Version Available
-----------------------------------------
Element Element.Element 1.10.1  1.10.3
1 upgrades available.
1 package has a version number that cannot be determined. Use "--include-unknown" to see all results.
PS C:\WINDOWS\system32> winget upgrade --include-unknown
Name    Id              Version Available
-----------------------------------------
Element Element.Element 1.10.1  1.10.3
1 upgrades available.

WinGet-2022-02-14-19-58-27.679_upgrade.log
WinGet-2022-02-14-19-58-35.901_IncludeUnknown.log

Environment

PS C:\WINDOWS\system32> winget --info
Windows Package Manager (Preview) v1.3.431-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19044.1526
Package: Microsoft.DesktopAppInstaller v1.18.431.0

Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir

Links
---------------------------------------------------------------------------
Privacy Statement   https://aka.ms/winget-privacy
License Agreement   https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Homepage            https://aka.ms/winget
Windows Store Terms https://www.microsoft.com/en-us/storedocs/terms-of-sale
PS C:\WINDOWS\system32>
@msftbot msftbot bot added the Needs-Triage label Feb 15, 2022
@jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Feb 15, 2022 •
edited

Per discussion in the gitter channel, it seems like winget is not checking to see if there is a version of the app in the repository before putting it into the count of unknown packages. So if there isn't something in the repo to "update" to, then it shouldn't add it to the count.

Shouldn't be that hard to fix, I'll try to write one if nobody else does.

WinDirStat is a package where this is true, as winget can't find a eligible package during upgrade due to another upgrade bug.

@Trenly
Copy link
Contributor Author

@Trenly Trenly commented Feb 15, 2022 •
edited

Another case that this happens is Nirsoft.BlueScreenView

Edit: Seems like there is also a second portion to this bug that even if --include-unknown is used, it doesn't check to see if there is a version available in the repo. It just always skips checking for upgrades entirely?

@jedieaston
Copy link
Contributor

@jedieaston jedieaston commented Feb 15, 2022 •
edited

It just always skips checking for upgrades entirely?

Not always, GOG shows up as available for upgrade with --include-unknown. I think there's some criteria these apps are missing, but I'm not sure what it is.

@OfficialEsco
Copy link

@OfficialEsco OfficialEsco commented Feb 15, 2022 

❯ winget upgrade
Name       Id                      Version Available
----------------------------------------------------
Oh My Posh JanDeDobbeleer.OhMyPosh 7.17.0  7.18.0
1 upgrades available.
12 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

❯ winget list
Name                                     Id                                                  Version
----------------------------------------------------------------------------------------------------------------
Battle.net                               Battle.net                                          Unknown
Call of Duty Black Ops Cold War          Call of Duty Black Ops Cold War                     Unknown
Call of Duty Modern Warfare              Call of Duty Modern Warfare                         Unknown
DuckieTV                                 DuckieTV                                            Unknown
ReaPlugs/x64                             ReaPlugs                                            Unknown
New World                                Steam App 1063730                                   Unknown
Forza Horizon 5                          Steam App 1551360                                   Unknown
Sid Meier's Civilization VI              Steam App 289070                                    Unknown
Factorio                                 Steam App 427520                                    Unknown
PUBG: BATTLEGROUNDS                      Steam App 578080                                    Unknown
Trackmania                               Uplay Install 5595                                  Unknown
VBCABLE, The Virtual Audio Cable         VB:VBCABLE {87459874-1236-4469}                     Unknown

I see you guys talking about BlueScreenView and WinDirStat, the reason these are getting picked up is because it doesn't match the metadata because the Publisher is blank and its missing the ProductCode 🙃

@denelon denelon added Issue-Bug and removed Needs-Triage labels Feb 15, 2022
@scottbeamer
Copy link

@scottbeamer scottbeamer commented Feb 20, 2022 •
edited

I'm having a similar issue.

`> winget upgrade --all

No installed package found matching input criteria.

2 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.

No applicable update found.

2 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.`

`> winget upgrade

No installed package found matching input criteria.
2 packages have version numbers that cannot be determined. Use "--include-unknown" to see all results.`

`> winget upgrade --include-unknown

No installed package found matching input criteria.`

Something is broken here.

@denelon denelon added this to the v1.3-Client milestone Feb 22, 2022
@denelon denelon mentioned this issue Feb 23, 2022
Closed
@Trenly Trenly mentioned this issue Feb 24, 2022
Merged
2 tasks
@msftbot msftbot bot added the In-PR label Feb 24, 2022
@msftbot msftbot bot added Resolution-Fix-Committed and removed In-PR labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Bug Resolution-Fix-Committed
Projects
None yet
Milestone
v1.3-Client
Development

Successfully merging a pull request may close this issue.

Fix: Only include unknown packages which exist in source Trenly/winget-cli
5 participants
@Trenly @OfficialEsco @jedieaston @denelon @scottbeamer