Let `Utils\run_mysql_command()` return data #5384

schlessera · 2020-04-16T10:23:11Z

Change the Utils\run_mysql_command() so that it can also return data & errors when running a query via the mysql binary.

Fixes #5383

aidvu · 2021-06-16T21:51:46Z

You're now storing the outputs in RAM, even if it's a wp db export and the chances of the command running out of memory are pretty high.

I think we should retain the old behavior if $send_to_shell === true. Not sure if you had any reports about this yet.

schlessera added 2 commits Apr 16, 2020

Adapt Utils\run_mysql_command() to allow return of data

591a531

Add tests

79d90bf

schlessera force-pushed the 5383-let-run-mysql-command-return-data branch from 766add2 to 79d90bf Compare Apr 16, 2020

Adapt tests

d196cbf

schlessera added breaking-change scope:framework labels Apr 16, 2020

schlessera added this to the 2.5.0 milestone Apr 16, 2020

schlessera added 8 commits Apr 16, 2020

Skip loading WP on tests

d9fb9a5

Refactor method to avoid pass-by-reference

f0db86c

Guard env access against missing password

47aa868

Fix strtoupper syntax

5e3bb0f

Revert mysql command back to what to using /usr/bin/env

b75448c

Refactor exit code behavior

1c50f01

Fix code and tests

af685c9

Use information_schema as DB name to check for

5af9537

schlessera mentioned this pull request Apr 17, 2020

Added "db get-rows" command wp-cli/db-command#153

Closed

schlessera marked this pull request as ready for review Apr 17, 2020

schlessera requested a review from a team as a code owner Apr 17, 2020

schlessera merged commit b702c72 into master Apr 17, 2020

schlessera deleted the 5383-let-run-mysql-command-return-data branch Apr 17, 2020

danielbachhuber mentioned this pull request Oct 3, 2022

Error on Windows 11 with WP CLI 2.6 and PHP 8.1.6 wp-cli/config-command#145

Closed

Let Utils\run_mysql_command() return data #5384