Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $wp_config_path param for get_wp_config_code() #5366

Merged

Conversation

pmbaldha
Copy link
Contributor

@schlessera
Copy link
Member

This should have a test in https://github.com/wp-cli/wp-cli/blob/master/features/wp-config.feature to make sure we don't introduce a regression later on.

@pmbaldha
Copy link
Contributor Author

@schlessera I am developing behat tests for it.

@pmbaldha
Copy link
Contributor Author

@schlessera I have added all behat tests for --config-file param in the https://github.com/wp-cli/config-command/pull/104/files

I am not understanding which tests I should write for this PR.

@schlessera
Copy link
Member

@pmbaldha My bad, I don't think we need a test here. This is not externally accessible, and the Behat test from the other package already tests it in terms of safeguarding it against a regression.

php/WP_CLI/Runner.php Outdated Show resolved Hide resolved
php/WP_CLI/Runner.php Outdated Show resolved Hide resolved
@pmbaldha pmbaldha requested a review from schlessera Apr 2, 2020
Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have included both old and new versions in the string... :)

php/WP_CLI/Runner.php Outdated Show resolved Hide resolved
@schlessera
Copy link
Member

Note: GitHub allows you to directly commit suggestions like the one I made above via the Commit suggestion button below the comment. That is generally less error-prone.

Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
@schlessera schlessera added this to the 2.5.0 milestone Apr 8, 2020
@schlessera schlessera merged commit d2a0022 into wp-cli:master Apr 8, 2020
@schlessera schlessera changed the title Add $wp_config_path param for get_wp_config_code Add $wp_config_path param for get_wp_config_code() Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants