Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for nonexistent plugins #115

Merged
merged 5 commits into from Sep 11, 2022
Merged

Add warning for nonexistent plugins #115

merged 5 commits into from Sep 11, 2022

Conversation

GeoJunkie
Copy link
Contributor

@GeoJunkie GeoJunkie commented Sep 11, 2022 •
edited

  • Adds a check to see if a plugin is installed before checking languages
  • If the plugin isn't installed, displays a warning
  • Adds a test to confirm this continues to work
  • Made some updates for themes

Fixes #86

@GeoJunkie GeoJunkie requested a review from a team as a code owner Sep 11, 2022
@schlessera schlessera added the bug label Sep 11, 2022
schlessera
schlessera requested changes Sep 11, 2022
View changes
src/Plugin_Language_Command.php Outdated Show resolved Hide resolved
@GeoJunkie GeoJunkie requested a review from schlessera Sep 11, 2022
schlessera
schlessera requested changes Sep 11, 2022
View changes
src/Theme_Language_Command.php Outdated Show resolved Hide resolved
@GeoJunkie @schlessera
Update src/Theme_Language_Command.php
ff9a338 
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@GeoJunkie GeoJunkie requested a review from schlessera Sep 11, 2022
@schlessera schlessera added this to the 2.0.13 milestone Sep 11, 2022
@schlessera schlessera merged commit 80713ba into wp-cli:main Sep 11, 2022
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
bug command:language-plugin-list command:language-theme-list
Projects
None yet
Milestone
2.0.13
Development

Successfully merging this pull request may close these issues.

language plugin list for bad plugin slugs should throw warning
2 participants
@GeoJunkie @schlessera