Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace one-time-login with a sample plugin in the tests #302

Merged
merged 4 commits into from Oct 13, 2021

Conversation

Nikschavan
Copy link
Contributor

@Nikschavan Nikschavan commented Oct 11, 2021

Fixes #301

Replaces the plugin one-time-login with a sample WordPress plugin

@Nikschavan Nikschavan requested a review from as a code owner Oct 11, 2021
@swissspidy
Copy link
Member

@swissspidy swissspidy commented Oct 11, 2021

@schlessera Should this sample plugin live in the wp-cli org so that we can guarantee it exists? In case https://github.com/Nikschavan/test-wordpress-plugin ever gets deleted :-)

@Nikschavan
Copy link
Contributor Author

@Nikschavan Nikschavan commented Oct 11, 2021

I was hoping it would be simpler to fork and get this into wp-cli org? I mentioned in the issue #301 it would be preferable to be in this org.

Maybe anyone with capabilities can create a repo here instead and I can use that links in this PR?

@wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Oct 11, 2021

We have https://github.com/wp-cli-test/generic-example-plugin or AFAIK we can transfer @Nikschavan to wp-cli-test organisation.

@Nikschavan
Copy link
Contributor Author

@Nikschavan Nikschavan commented Oct 11, 2021

Ahh, I didn't knew about the generic-example-plugin. That should work for this use case as well. I will use that one instead of creating a new one. Thanks @wojsmol :)

features/plugin-install.feature Outdated Show resolved Hide resolved
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@Nikschavan
Copy link
Contributor Author

@Nikschavan Nikschavan commented Oct 11, 2021

I will need one more help from folks who have access to the repo https://github.com/wp-cli-test/generic-example-plugin.

One of the tests will require a release to be created for the plugin generic-exaple-plugin and a ZIP file to be uploaded to the release, Same as the release on one-time-login plugin - https://github.com/danielbachhuber/one-time-login/releases/tag/v0.1.2

@swissspidy
Copy link
Member

@swissspidy swissspidy commented Oct 11, 2021

That'd have to be @schlessera in that case

@schlessera
Copy link
Member

@schlessera schlessera commented Oct 12, 2021

@Nikschavan This is done, the repo now has two published releases, each with a separate ZIP as attached asset.

features/plugin-install.feature Outdated Show resolved Hide resolved
Co-authored-by: Wojciech Smoliński <wojsmol@wp.pl>
@schlessera schlessera merged commit 82bdf8b into wp-cli:master Oct 13, 2021
24 checks passed
@Nikschavan Nikschavan deleted the 301-php56-tests branch Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants