Skip to content

Check for WP_Error on bulk updates #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schlessera merged 1 commit into from
Aug 6, 2021
Merged

Check for WP_Error on bulk updates #294

schlessera merged 1 commit into from
Aug 6, 2021

Conversation

@schlessera
Copy link
Member

@schlessera schlessera commented Aug 6, 2021

The bulk upgrades were only detecting a null value of $result as an error. This PR adds detection for $result being a WP_Error instance as well.

@schlessera schlessera added bug command:plugin-update Related to 'plugin update' command command:theme-update Related to 'theme update' command labels Aug 6, 2021
@schlessera schlessera requested a review from a team as a code owner August 6, 2021 10:46
@schlessera schlessera added this to the 2.1.2 milestone Aug 6, 2021
@schlessera schlessera merged commit a015917 into master Aug 6, 2021
@schlessera schlessera deleted the fix/plugin-update-status-on-trunk branch August 6, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

bug command:plugin-update Related to 'plugin update' command command:theme-update Related to 'theme update' command

Projects

None yet

Milestone

2.1.2

Development

Successfully merging this pull request may close these issues.

3 participants

@schlessera @swissspidy