Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type handling and remove unused variables #84

Merged
merged 1 commit into from May 11, 2021
Merged

Improve type handling and remove unused variables #84

merged 1 commit into from May 11, 2021

Conversation

schlessera
Copy link
Member

This PR adds a few minor tweaks in terms of code correctness.

Most importantly, it fixes an issue that might lead to the following notice:

PHP Warning:  Trying to access array offset on value of type int in /wp-includes/formatting.php on line 884

Related wp-cli/wp-cli#5479

@schlessera schlessera requested a review from a team as a code owner May 11, 2021
@schlessera schlessera added this to the 2.0.8 milestone May 11, 2021
@schlessera schlessera merged commit 883fd8d into master May 11, 2021
24 checks passed
@schlessera schlessera deleted the fix/type-correctness branch May 11, 2021
@schlessera schlessera mentioned this pull request May 11, 2021
Closed
@schlessera schlessera changed the title Improve tyoe handling and remove unused variables Improve type handling and remove unused variables May 11, 2021
This was referenced Jul 25, 2021
Merged
Closed
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@schlessera
Merge pull request #84 from wp-cli/fix/type-correctness
559ff89 
Improve tyoe handling and remove unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-cli/committers committers

Assignees
No one assigned
Labels
bug command:export
Projects
None yet
Milestone
2.0.8
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@schlessera