Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve __FILE__/__DIR__ regex pattern #44

Merged
merged 4 commits into from Feb 6, 2020

Conversation

schlessera
Copy link
Member

The previous pattern would erroneously match a string like SOMETHING__FILE__.

See https://regex101.com/r/9hXp5d/4/ for the new pattern.

@schlessera schlessera requested a review from a team as a code owner Feb 5, 2020
@schlessera schlessera changed the title Improve __FILE__/__DIR__ regex pattern Improve __FILE__/__DIR__ regex pattern Feb 5, 2020
@schlessera schlessera added this to the 2.0.6 milestone Feb 5, 2020
@schlessera schlessera merged commit d379732 into master Feb 6, 2020
@schlessera schlessera deleted the improve-file-dir-regex-pattern branch Feb 6, 2020
schlessera added a commit that referenced this pull request Jan 5, 2022
Improve `__FILE__`/`__DIR__` regex pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant