Show error when parameter is missing in wp option patch #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| Please provide value to update. | ||
| """ | ||
| And the return code should be 1 |
Member
There was a problem hiding this comment.
Can we add a test case for:
When I run `wp option patch update option_name foo 0`
To make sure we're handling falsy values correctly?
Contributor
Author
There was a problem hiding this comment.
It should not allow this to update, right?
Member
There was a problem hiding this comment.
It should not allow this to update, right?
Perhaps I'm misunderstanding but isn't 0 a valid value?
Contributor
Author
There was a problem hiding this comment.
Actually, I misunderstood.
I thought zero should be considered an empty value.
Then I saw other commands in the same option-pluck-patch.feature file.
So fixe it.
danielbachhuber
approved these changes
Sep 12, 2022
Member
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the updates!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353