Skip to content

Conversation

@xyulex
Copy link
Contributor

@xyulex xyulex commented Jun 2, 2022

Fixes #202

@xyulex xyulex requested a review from a team as a code owner June 2, 2022 15:10
@xyulex
Copy link
Contributor Author

xyulex commented Jun 3, 2022

@schlessera I just created the remaining commit from the Contributor Day. Let me know if you find something I need to change :)

@janw-me
Copy link
Member

janw-me commented Jun 6, 2022

I might misunderstand the code or the issue. But where is the archive(zip? tar? not sure what it is) file located after running this?
It would make sense to cover this in the tests as well, and check for the existence of the archive file when using this flag.

@swissspidy swissspidy changed the title Adding extract parameter [ https://github.com/wp-cli/core-command/issues/202 ] Adding extract parameter Jun 6, 2022
@xyulex
Copy link
Contributor Author

xyulex commented Jun 7, 2022

@janw-me I discussed the code with @schlessera at Contributor Day and didn't seem to be needed. Let me know if it's necessary in this moment.

@xyulex xyulex changed the title Adding extract parameter Adding extract parameter [WCEU 2022] Jun 8, 2022
xyulex and others added 4 commits July 1, 2022 11:33
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@schlessera schlessera merged commit 61e8fcb into wp-cli:master Jul 2, 2022
@schlessera schlessera changed the title Adding extract parameter [WCEU 2022] Add --extract flag to core download Jul 2, 2022
@schlessera schlessera added this to the 2.1.2 milestone Jul 2, 2022
@schlessera
Copy link
Member

Thanks for the PR, @xyulex !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support --no-extract in wp core download

4 participants