Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB Upgrade tests for PHP 7.4 #162

Merged
merged 3 commits into from Jul 4, 2020
Merged

Fix DB Upgrade tests for PHP 7.4 #162

merged 3 commits into from Jul 4, 2020

Conversation

schlessera
Copy link
Member

@schlessera schlessera commented Jul 4, 2020 •
edited

The notices on PHP 7.4 were caused by the fact that we pulled in WP 4.1 for testing the DB upgrade procedure, and 4.1 is not fully compatible with PHP 7.4, of course.

@schlessera schlessera requested a review from a team as a code owner Jul 4, 2020
@schlessera schlessera added this to the 2.0.9 milestone Jul 4, 2020
@schlessera schlessera merged commit 429c0d2 into master Jul 4, 2020
1 check passed
@schlessera schlessera deleted the fix-db-upgrade-test-for-php-7-4 branch Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp-cli/committers committers

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.0.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@schlessera