Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale parameter #133

Merged
merged 11 commits into from Aug 26, 2022
Merged

Add locale parameter #133

merged 11 commits into from Aug 26, 2022

Conversation

2ndkauboy
Copy link
Contributor

@2ndkauboy 2ndkauboy commented Oct 4, 2019

Add a locale parameter to the core install command allowing localized installs.

Fixes #104.

@2ndkauboy 2ndkauboy requested a review from a team as a code owner Oct 4, 2019
@2ndkauboy 2ndkauboy changed the title 104 add locale parameter Add locale parameter Oct 4, 2019
@2ndkauboy 2ndkauboy force-pushed the 104-add-locale-parameter branch 2 times, most recently from e9241b7 to a69ccce Compare Oct 4, 2019
@schlessera
Copy link
Member

schlessera commented Oct 8, 2019

Thanks for the PR, @2ndkauboy !

Please merge latest master into this PR to get the fix for the failed test against WordPress trunk.

schlessera
schlessera requested changes Oct 8, 2019
View changes
src/Core_Command.php Show resolved Hide resolved
src/Core_Command.php Outdated Show resolved Hide resolved
features/core-install.feature Outdated Show resolved Hide resolved
src/Core_Command.php Outdated Show resolved Hide resolved
src/Core_Command.php Outdated Show resolved Hide resolved
@ottok
Copy link
Contributor

ottok commented May 24, 2020

@2ndkauboy Did you notice you got feedback here?

@2ndkauboy
Copy link
Contributor Author

2ndkauboy commented May 25, 2020

@ottok no I haven't, thanks for the ping!

@lewebsimple
Copy link

lewebsimple commented Mar 22, 2022

Can we get this merged please ?

@schlessera schlessera force-pushed the 104-add-locale-parameter branch from 6a4b688 to 5eeee63 Compare Aug 25, 2022
@schlessera schlessera added this to the 2.1.3 milestone Aug 25, 2022
@schlessera schlessera force-pushed the 104-add-locale-parameter branch from d913571 to d72cdd0 Compare Aug 26, 2022
@schlessera schlessera merged commit ea2adda into wp-cli:master Aug 26, 2022
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera

Assignees
No one assigned
Labels
command:core-install
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.

Add language/locale parameter to "wp core install" command
4 participants
@2ndkauboy @schlessera @ottok @lewebsimple