Require selection argument on install/show/search/uninstall #2125
Conversation
…rt of selection criteria
| { | ||
| if (args.Contains(type)) | ||
| { | ||
| return; |
There was a problem hiding this comment.
Would it be possible to ensure the query is also not an empty string?
#1249
There was a problem hiding this comment.
It would be possible, but allowing an empty string does allow for an effective --all being "". The current change prevents accidental "everything" searches, which I feel was the primary value. Preventing intentional searching for everything seems like it would be due to the current performance limitations rather than due to protecting users.
If the user types in winget search "", it could be an accident, but it is more likely that it is intentional than winget search. I could see scripts constructing the command line resulting in more frequent empty strings as well, but if the script author wants to block that, they can.
Without any other reasons, I'm not inclined to block the empty strings.
There was a problem hiding this comment.
I think those are fair points, and are things I hadn't considered. After thinking more, I do agree that simply requiring an argument solves the potential issues here
Fixes #1131
Change
For
install,show,search, anduninstallcommands, require that one of the selection arguments be provided. These are (where appropriate per command):I intentionally did not provide a way to override this behavior (like an
--allforsearch), because I don't see a good use case for it. If there is one, please explain it below.Microsoft Reviewers: Open in CodeFlow