Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid panic when bad default given to Select #6831

Merged
merged 1 commit into from Jan 10, 2023
Merged

avoid panic when bad default given to Select #6831

merged 1 commit into from Jan 10, 2023

Conversation

vilmibm
Copy link
Member

@vilmibm vilmibm commented Jan 9, 2023 •
edited

As suggested by @mislav in #6810 this PR prevents a panic if a bad default is given to Select

Fixes #6808

@vilmibm vilmibm requested a review from a team as a code owner Jan 9, 2023
@vilmibm vilmibm requested review from samcoe and removed request for a team Jan 9, 2023
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jan 9, 2023
@vilmibm vilmibm mentioned this pull request Jan 9, 2023
Closed
samcoe
samcoe approved these changes Jan 9, 2023
View changes
The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 9, 2023
@vilmibm vilmibm merged commit fc21c87 into trunk Jan 10, 2023
11 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 10, 2023
@vilmibm vilmibm deleted the select-default-blank branch Jan 10, 2023
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe

Assignees

@vilmibm vilmibm

Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gh repo set-default produces panic: runtime error: index out of range [-1]
2 participants
@vilmibm @samcoe