Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update codespace installation instructions #6781

Merged
merged 1 commit into from Jan 3, 2023
Merged

docs: update codespace installation instructions #6781

merged 1 commit into from Jan 3, 2023
+1 −1

Conversation

levenleven
Copy link
Contributor

Update Codespace installation instructions to use recommended feature. Currently following warning is printed when building devcontainer:

WARNING: Using the deprecated 'github-cli' Feature. See https://github.com/devcontainers/features/tree/main/src/github-cli#example-usage for the updated Feature.

@levenleven levenleven requested a review from a team as a code owner Dec 23, 2022
@levenleven levenleven requested review from mislav and removed request for a team Dec 23, 2022
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Dec 23, 2022
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Dec 23, 2022
samcoe
samcoe approved these changes Jan 3, 2023
View changes
Copy link
Member

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping our docs up to date!

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Jan 3, 2023
@samcoe samcoe enabled auto-merge (squash) Jan 3, 2023
@samcoe samcoe merged commit c03b6ce into cli:trunk Jan 3, 2023
4 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Jan 3, 2023
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samcoe samcoe

@mislav mislav

Assignees
No one assigned
Labels
external pull request originating outside of the CLI core team
Projects
The GitHub CLI
  
Done 💤
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@levenleven @cliAutomation @samcoe