Skip to content

Specify language names in extractor packs#11783

Merged
henrymercer merged 1 commit intomainfrom
henrymercer/specify-baseline-languages
Jan 4, 2023
Merged

Specify language names in extractor packs#11783
henrymercer merged 1 commit intomainfrom
henrymercer/specify-baseline-languages

Conversation

@henrymercer
Copy link
Contributor

This PR specifies GitHub API and SCC language names in the codeql-extractor.yml file for extractor packs defined within github/semmle-code. These properties define how language autodetection and baseline information is computed.

This functionality was introduced in CodeQL CLI 2.11.4, and lets us avoid hardcoding this information in the CLI. The overall goal is to minimise the number of places we need to modify to define a new language.

Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For Ruby

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# LGTM

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL 👍

Copy link
Contributor

@owen-mc owen-mc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Go

@henrymercer henrymercer merged commit b96160f into main Jan 4, 2023
@henrymercer henrymercer deleted the henrymercer/specify-baseline-languages branch January 4, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants