Add stubs for influxdb-client #9429
Merged
+13,859
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The homeassistant primer warning is genuine. The |
This comment has been minimized.
This comment has been minimized.
JelleZijlstra
reviewed
Dec 30, 2022
| | bytes | ||
| | Iterable[bytes] | ||
| | _Observable | ||
| | NamedTuple |
There was a problem hiding this comment.
Mypy accepts NamedTuple as a type annotation but I'm not sure that's a feature we can rely on in typeshed.
There was a problem hiding this comment.
I've used a type alias to tuple[Any, ...] for now, similar to what I did to dataclass.
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ homeassistant/components/influxdb/__init__.py:352: error: Argument 1 to "InfluxDBClient" has incompatible type "**Dict[str, int]"; expected "Optional[str]" [arg-type]
+ homeassistant/components/influxdb/__init__.py:352: error: Argument 1 to "InfluxDBClient" has incompatible type "**Dict[str, int]"; expected "bool" [arg-type]
+ homeassistant/components/influxdb/__init__.py:352: error: Argument 1 to "InfluxDBClient" has incompatible type "**Dict[str, int]"; expected "Optional[Dict[Any, Any]]" [arg-type]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Except for
client.util.date_utils, the stubs were auto-generated and then manually fixed/cleaned up. This is best reviewed commit by commit, where the first commit is just the output of create_baseline_stubs.Upstream annotations were cleaned up, but not reviewed. I'm sure that the many
dict/listannotations could be made more lenient, but I didn't check review that.