Upgrade GitHub Actions for release process #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
reviewed
Jul 17, 2022
|
|
||
| - name: Build source distribution | ||
| run: | | ||
| python -m pip install -U setuptools wheel pip | ||
| python -m pip install --upgrade setuptools wheel pip |
There was a problem hiding this comment.
pip install has command line options for:
--upgrade
--upgrade-strategy
--user
--use-pep517
In a workflow, it is better to be explicit about which of these four we are using.
fantix
approved these changes
Jul 17, 2022
|
@fantix @cclauss I think those changes will make the release workflow fail. See #447 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.