Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark test-watch-mode* as flaky on all platforms #45049

Merged
merged 1 commit into from Oct 20, 2022

Conversation

pbo-linaro
Copy link
Contributor

@pbo-linaro pbo-linaro commented Oct 18, 2022

This was confirmed flaky on those platforms:

  • Windows x64
  • Windows on Arm
  • Linux
  • Freebsd

Tests randomly fail because of bad order in messages expected, which seems related to threads scheduling at execution.

Discussed in issue #44898

This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2022
MoLow
MoLow approved these changes Oct 18, 2022
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Oct 18, 2022

@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Oct 18, 2022
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Oct 18, 2022

@pbo-linaro
Copy link
Contributor Author

pbo-linaro commented Oct 18, 2022

Failure reported is on a machine running x86 testsuite, and is not related to this PR, but simply to a disk that is full.

not ok 276 parallel/test-fs-readfile
11:36:51   ---
11:36:51   duration_ms: 0.960
...
11:36:51     Can't clean tmpdir: C:\workspace\node-test-binary-windows-js-suites\node\test\.tmp.265
11:36:51     Files blocking: [
11:36:51       '.removeme-fs-readfile-4020-1K.txt',
11:36:51       '.removeme-fs-readfile-4020-1M.txt',
11:36:51       '.removeme-fs-readfile-4020-1MPlusOne.txt',
11:36:51       '.removeme-fs-readfile-4020-64K.txt',
11:36:51       '.removeme-fs-readfile-4020-64KLessOne.txt'
...
11:36:51     Error: ENOSPC: no space left on device, ftruncate

@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Oct 19, 2022

@pbo-linaro
Copy link
Contributor Author

pbo-linaro commented Oct 20, 2022

Does someone knows who we can ping to get this merged?

@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 806ea92 into nodejs:main Oct 20, 2022
57 checks passed
@nodejs-github-bot
Copy link
Contributor

nodejs-github-bot commented Oct 20, 2022

Landed in 806ea92

@pbo-linaro
Copy link
Contributor Author

pbo-linaro commented Oct 20, 2022

Thanks @MoLow !

RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: #45049
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
This was confirmed flaky on those platforms:
- Windows x64
- Windows on Arm
- Linux
- Freebsd

Tests randomly fail because of bad order in messages expected, which
seems related to threads scheduling at execution.

PR-URL: #45049
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. watch-mode Issues and PRs related to watch mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants