[v18.x] build: fix bad backport #44642
Closed
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream merge of nodejs@e27e709d3c accidentally removed code related to systemtap and dtrace. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com>
|
For the record, the merge to the |
|
Thanks @sgallagher. @nodejs/releasers should we land a patch? or it's fine to wait for v18.10 (2022-09-20)? |
richardlau
approved these changes
Sep 14, 2022
This doesn't affect our release binaries but may affect those building from source. I think we land this on v18.x-staging but it can wait for the next release of 18.x. |
|
I agree, it can wait for 18.10. I'll carry the patch locally for Fedora in the meantime. |
|
Landed in 1315a83 |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 23, 2022
The upstream merge of e27e709d3c accidentally removed code related to systemtap and dtrace. Signed-off-by: Stephen Gallagher <sgallagh@redhat.com> PR-URL: #44642 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The upstream merge of e27e709d3c
into v18 accidentally removed code related to systemtap and dtrace.
Signed-off-by: Stephen Gallagher sgallagh@redhat.com