Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching issue/PR comments #6779

Merged
merged 1 commit into from Dec 23, 2022
Merged

Fix fetching issue/PR comments #6779

merged 1 commit into from Dec 23, 2022

Conversation

mislav
Copy link
Member

@mislav mislav commented Dec 23, 2022

The "Author" struct was too overloaded in different types of queries that treat struct fields in incompatible ways. This change defines a simpler CommentAuthor struct for use in comments until we can figure out how to query ... on User information for comments too.

Followup to #5049
Fixes #6778

Ref. 1440fd8

The "Author" struct was too overloaded in different types of queries that treat struct fields in incompatible ways. This change defines a simpler CommentAuthor struct for use in comments until we can figure out how to query `... on User` information for comments too.
@mislav mislav requested a review from a team as a code owner Dec 23, 2022
@mislav mislav requested review from samcoe and removed request for a team Dec 23, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Dec 23, 2022
@mislav mislav merged commit 6618baa into trunk Dec 23, 2022
11 checks passed
The GitHub CLI automation moved this from Needs review 🤔 to Pending Release 🥚 Dec 23, 2022
@mislav mislav deleted the fix-comments-author branch Dec 23, 2022
@github-actions github-actions bot moved this from Pending Release 🥚 to Done 💤 in The GitHub CLI Dec 23, 2022
@ss0614484312

This comment has been minimized.

@timscharfenort8989

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
The GitHub CLI
  
Done 💤
Development

Successfully merging this pull request may close these issues.

gh issue view with --comments fails with GraphQL error
4 participants