Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update installation instructions for WinGet #6716

Merged
merged 3 commits into from Dec 12, 2022

Conversation

vegerot
Copy link
Contributor

@vegerot vegerot commented Dec 10, 2022

After running winget install --id GitHub.cli I spent fifteen minutes trying to figure out why it didn't work. My first thought was something to do with the PATH, so I opened a new PowerShell tab. When that didn't work, I spent 14 more minutes trying to figure out what went wrong.

I think giving specific instructions will help other developers like me.

Continuation from #4772 (comment)

@vegerot vegerot requested a review from a team as a code owner Dec 10, 2022
@vegerot vegerot requested review from mislav and removed request for a team Dec 10, 2022
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Dec 10, 2022
@cliAutomation
Copy link
Collaborator

cliAutomation commented Dec 10, 2022

Thanks for the pull request! We're a small team and it's helpful to have context around community submissions in order to review them appropriately. Our automation has closed this pull request since it does not have an adequate description. Please edit the body of this pull request to describe what this does, then reopen it.

Copy link
Contributor Author

@vegerot vegerot left a comment

Continuation from #4772 (comment)

After running winget install --id GitHub.cli I spent fifteen minutes trying to figure out why it didn't work. My first thought was something to do with the PATH, so I opened a new PowerShell tab. When that didn't work, I spent 14 more minutes trying to figure out what went wrong.

I think giving specific instructions will help other developers like me.

@mislav mislav reopened this Dec 12, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Dec 12, 2022
mislav
mislav approved these changes Dec 12, 2022
Copy link
Member

@mislav mislav left a comment

Thank you!

Ref. microsoft/winget-cli#222

The GitHub CLI automation moved this from Needs review 🤔 to Needs to be merged 🎉 Dec 12, 2022
@mislav mislav enabled auto-merge (squash) Dec 12, 2022
@mislav mislav merged commit f57249f into cli:trunk Dec 12, 2022
3 checks passed
The GitHub CLI automation moved this from Needs to be merged 🎉 to Pending Release 🥚 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external pull request originating outside of the CLI core team
Projects
The GitHub CLI
  
Pending Release 🥚
Development

Successfully merging this pull request may close these issues.

None yet

3 participants