CodeQL alert suppression #11723
Merged
CodeQL alert suppression #11723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81db2ad
to
e792222
Compare
ef74927
to
bce2b47
Compare
erik-krogh
reviewed
Dec 20, 2022
|
|
||
| CodeQlSuppressionComment() { | ||
| // match `codeql[...]` anywhere in the comment | ||
| annotation = this.(Comment).getText().regexpFind("(?i)\\bcodeql\\s*\\[[^\\]]*\\]", _, _) and |
There was a problem hiding this comment.
Suggested change
| annotation = this.(Comment).getText().regexpFind("(?i)\\bcodeql\\s*\\[[^\\]]*\\]", _, _) and | |
| annotation = this.getText().regexpFind("(?i)\\bcodeql\\s*\\[[^\\]]*\\]", _, _) and |
Redundant cast?
There was a problem hiding this comment.
It looked redundant to me too, but the results are empty without it. @alexet do you know why that is?
erik-krogh
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This pull request changes the alert suppression queries to accept:
lgtmandlgtm[query-id]comments on the line before an alertcodeql[query-id]on the line before an alertNote that the legacy
lgtmandlgtm[query-id]comments are still accepted on the same line as an alert, but the newcodeql[query-id]comments are not.