gh-93297: Make asyncio task groups prevent child tasks from being GCed #93299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
approved these changes
May 27, 2022
Okay, but it looks like self._unfinished_tasks is now redundant -- it is always equal to len(self._tasks), isn't it?
Yeah, true. The code looks cleaner now, please see the updated diff. |
|
Thanks @1st1 for the PR |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
May 27, 2022
…ng GCed (pythonGH-93299) (cherry picked from commit e6a5767) Co-authored-by: Yury Selivanov <yury@edgedb.com>
|
GH-93305 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.