Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (GH-95272) #95272

Merged
merged 1 commit into from Jul 31, 2022
Merged

[3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (GH-95272) #95272

merged 1 commit into from Jul 31, 2022

Conversation

tiran
Copy link
Member

@tiran tiran commented Jul 26, 2022 •
edited by bedevere-bot

  • check for dup() libc function
  • handle missing F_DUPFD in dup2() replacement function
  • add workaround for WASI libc bug in MSG_TRUNC
  • ESHUTDOWN is missing, use EPIPE instead
  • POLLPRI is missing, define as 0 (no-op).
    (cherry picked from commit 0d35a59)

Co-authored-by: Christian Heimes christian@python.org

@tiran tiran requested a review from a team as a code owner Jul 26, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jul 26, 2022
Merged
@ambv
Copy link
Contributor

ambv commented Jul 26, 2022

Looks like a large-ish change. @pablogsal, you press the green button.

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 26, 2022

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit c988300e24cfdc235b343a9ab4f2ec7a2a917d44 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 26, 2022
@tiran
Copy link
Member Author

tiran commented Jul 27, 2022

@pablogsal are you ok with this changeset? It only affects wasm32-wasi builds. The two test failures are unrelated.

@tiran tiran mentioned this pull request Jul 27, 2022
Merged
@tiran
[3.11] pythongh-95174: Handle missing dup() and constants in WASI (py…
dfdb0d3 
…thonGH-95229)

- check for ``dup()`` libc function
- handle missing ``F_DUPFD`` in ``dup2()`` replacement function
- add workaround for WASI libc bug in MSG_TRUNC
- ESHUTDOWN is missing, use EPIPE instead
- POLLPRI is missing, define as 0 (no-op).
(cherry picked from commit 0d35a59)

Co-authored-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the backport-0d35a59-3.11 branch from c988300 to dfdb0d3 Compare Jul 31, 2022
@tiran
Copy link
Member Author

tiran commented Jul 31, 2022

Rebased on latest 3.11, fixed a conflict in auto-generated files.

@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 31, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit dfdb0d3 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 31, 2022
@pablogsal pablogsal changed the title [3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) [3.11] gh-95174: Handle missing dup() and constants in WASI (GH-95229) (GH-95272) Jul 31, 2022
@pablogsal pablogsal merged commit db13c0c into python:3.11 Jul 31, 2022
83 of 84 checks passed
@tiran tiran deleted the backport-0d35a59-3.11 branch Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@python/windows-team windows-team

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tiran @ambv @bedevere-bot @pablogsal